Merged
Conversation
AlexanderLanin
requested review from
MaximilianSoerenPollak and
dcalavrezo-qorix
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the external needs handling code and updates configuration files. The main purpose is to improve code organization by extracting logic from a large function into smaller, more focused functions.
- Extracted external needs source retrieval logic into
get_external_needs_source()function - Extracted JSON file processing logic into
add_external_needs_json()function - Removed extra index URL from requirements files and added plantuml extension to docs configuration
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/requirements.txt | Removed extra PyPI index URL line (cleanup) |
| src/requirements.in | Removed extra PyPI index URL line (cleanup) |
| src/extensions/score_metamodel/external_needs.py | Refactored connect_external_needs() by extracting two new functions for better code organization |
| docs/conf.py | Added explicit sphinxcontrib.plantuml extension with TODO comment for sphinx-needs 6 migration |
| MODULE.bazel | Version bump from 1.4.0 to 1.5.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AlexanderLanin
force-pushed
the
cleanup
branch
from
c508493 to
0323b52
Compare
Member
Author
|
The created documentation from the pull request is available at: docu-html |
a-zw
approved these changes
Nov 4, 2025
a-zw
approved these changes
Nov 4, 2025
github-project-automation
bot
moved this from Draft
to Done
in INF - Infrastructure Community
arnoox
pushed a commit
to arnoox/score-docs-as-code
that referenced
this pull request
Feb 20, 2026
* Prepare 1.5.0 release * fix: plantuml dependency * remove useless extra index url from python requirements * refactor: split huge function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Several unrelated cleanups, see individual commits. See Copilot summary.
Do not squash.
🚨 Impact Analysis
✅ Checklist