Renaming in com_api#16
Open
piotrchodorowski wants to merge 1 commit intoeclipse-score:main_api_rsfrom
Open
Conversation
darkwisebear
suggested changes
Oct 22, 2025
Contributor
There was a problem hiding this comment.
I personally couldn't care less, but let's coordinate this a bit better:
- Renaming Runtime -> Adapter should be discussed in the COM round so that also C++ people are ok with that, as naming should be close. If it has been discussed, please add a reference to the discussion and a link to the respective ticket for the change in C++.
- Adding a
Conceptsuffix should be discussed in the Rust community and added as an explicit guideline at https://eclipse-score.github.io/score/main/contribute/development/rust/rust_api_design.html. I personally do not see the point, as 1. it's a trait, so it's by definition a concept and 2. it's part of a crate called "*.concept.*", so if anyone wants to explicitly show that in the source, they could just add the crate name when referencing the type.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR contains only renaming of API's contents to improve overall readability.
It is intended to not add any functional changes here which will be provided in further PRs.