fix: rename SimpleRng::next_u32 to next#64
Merged
pawelrutkaq merged 3 commits intoeclipse-score:mainfrom Feb 27, 2026
Merged
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
The function returns u64, not u32, making the name misleading. Rename to `next` to accurately reflect the return type. Closes eclipse-score#13 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The created documentation from the pull request is available at: docu-html |
0f64c19 to
ed86817
Compare
pawelrutkaq
reviewed
Feb 23, 2026
src/kyron/src/time/mod.rs
Outdated
|
|
||
| // Linear Congruential Generator (LCG) | ||
| fn next_u32(&mut self) -> u64 { | ||
| fn next(&mut self) -> u64 { |
Contributor
There was a problem hiding this comment.
next is clashing with the iterator name and was failing on some clippy. I wonder why it does not clash now. https://doc.rust-lang.org/std/iter/trait.Iterator.html#tymethod.next
maybe next_64 or someother name ?
c7865d5 to
d0ecb66
Compare
The name `next` conflicts with Iterator::next and triggers clippy's should_implement_trait lint. Use next_u64 which accurately reflects the u64 return type and avoids the naming collision. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
d0ecb66 to
c314db8
Compare
Contributor
Author
|
@pawelrutkaq all green please take a look |
pawelrutkaq
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SimpleRng::next_u32toSimpleRng::nextinsrc/kyron/src/time/mod.rs(test-only code)u64, notu32, making the previous name misleadinggen_range()and 2 direct usages in fuzzy testsTest plan
bazel test //src/kyron:tests— PASSED before and after fixbazel test //...— all 8 test targets PASSEDbazel build //...— full build SUCCESSCloses #13
🤖 Generated with Claude Code