hmon: fix Cargo build, small code changes

[arkjedrz]

• Fix Cargo for health_monitoring_lib.
• Fix leftover test changes from previous PR.
• Small code changes.

[github-actions]

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: a42c23ed-f669-482c-bb7b-cf3792edf07d
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'score_rust_policies', the root module requires module version score_rust_policies@0.0.3, but got score_rust_policies@0.0.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (31 packages loaded, 9 targets configured)

Analyzing: target //:license-check (76 packages loaded, 9 targets configured)

Analyzing: target //:license-check (86 packages loaded, 9 targets configured)

Analyzing: target //:license-check (139 packages loaded, 1575 targets configured)

Analyzing: target //:license-check (148 packages loaded, 5178 targets configured)

Analyzing: target //:license-check (160 packages loaded, 7815 targets configured)

Analyzing: target //:license-check (160 packages loaded, 7817 targets configured)

Analyzing: target //:license-check (161 packages loaded, 7941 targets configured)

INFO: Analyzed target //:license-check (165 packages loaded, 9955 targets configured).
[7 / 16] [Prepa] Expanding template license.check.license_check
[13 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox
[15 / 16] [Sched] Building license.check.license_check.jar ()
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 29.115s, Critical Path: 2.59s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

[Copilot]

Pull request overview

This PR refactors the supervisor API client implementations into a separate module with proper feature flag support, fixes Cargo build configuration, and improves test reliability.

Changes:

• Extracted SupervisorAPIClient trait and implementations (StubSupervisorAPIClient, ScoreSupervisorAPIClient) from worker.rs into a new supervisor_api_client module with feature-flag-based selection
• Fixed Cargo build by making monitor_rs dependency optional and adding mutually exclusive feature flags (stub_supervisor_api_client and score_supervisor_api_client)
• Replaced brittle hash value test in tag.rs with robust equality/inequality tests

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/health_monitoring_lib/rust/worker.rs	Removed supervisor API client implementations, updated imports to use new module, simplified Duration usage, made Checks enum pub(crate) for cross-module access
src/health_monitoring_lib/rust/supervisor_api_client/mod.rs	New module defining SupervisorAPIClient trait with compile-time feature flag enforcement for mutual exclusivity
src/health_monitoring_lib/rust/supervisor_api_client/stub_supervisor_api_client.rs	Stub implementation moved from worker.rs, used for testing
src/health_monitoring_lib/rust/supervisor_api_client/score_supervisor_api_client.rs	Score implementation moved from worker.rs, uses monitor_rs for production
src/health_monitoring_lib/rust/lib.rs	Updated to use SupervisorAPIClientImpl type alias from supervisor_api_client module
src/health_monitoring_lib/rust/tag.rs	Fixed brittle test that checked specific hash value; replaced with equality/inequality tests
src/health_monitoring_lib/Cargo.toml	Made monitor_rs optional, added feature flags with stub as default, removed extra blank line
src/health_monitoring_lib/BUILD	Added crate_features to rust targets to select appropriate supervisor API client
Cargo.toml	Added default-members to focus on health_monitoring_lib for development
.vscode/settings.json	Added rust-analyzer cargo features configuration for stub_supervisor_api_client
.github/workflows/lint_clippy.yml	Updated to test both feature flags independently

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

The created documentation from the pull request is available at: docu-html

[pawelrutkaq]

Why is this needed here? There may be two implementations functionaning in system. Currently the only limiation is that you cannot inject them in start of health monitor but other than that, nothing prevents to impement N of them or ?

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

There’s currently no compile-time guard to prevent enabling both score_supervisor_api_client and stub_supervisor_api_client (or neither). Adding compile_error! checks for these invalid feature combinations would prevent surprising runtime selection and avoid Cargo configurations that otherwise fail to compile.