impl: logging support by arkjedrz · Pull Request #206 · eclipse-score/persistency

arkjedrz · 2026-01-07T15:01:43Z

Use stdout_logger for Cargo builds.
Use score_log_bridge for Bazel builds.
Additional logs from Rust implementation.
Use proxy module for logging with correct context across the lib.
Fix tests.

github-actions · 2026-01-07T15:02:43Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
2026/02/20 08:32:28 Downloading https://releases.bazel.build/8.4.2/release/bazel-8.4.2-linux-x86_64...
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: e834b1ab-2b44-4727-aefe-ea09930876de
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.8.3 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_rust_policies', the root module requires module version score_rust_policies@0.0.4, but got score_rust_policies@0.0.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.2, but got rules_cc@0.2.16 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0.bcr.1, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'google_benchmark', the root module requires module version google_benchmark@1.9.4, but got google_benchmark@1.9.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 3 packages loaded
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Loading: 3 packages loaded
    currently loading: 
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)
Analyzing: target //:license-check (4 packages loaded, 0 targets configured)

Analyzing: target //:license-check (31 packages loaded, 10 targets configured)

Analyzing: target //:license-check (72 packages loaded, 10 targets configured)

Analyzing: target //:license-check (75 packages loaded, 10 targets configured)

Analyzing: target //:license-check (101 packages loaded, 26 targets configured)

Analyzing: target //:license-check (156 packages loaded, 1202 targets configured)

Analyzing: target //:license-check (158 packages loaded, 3431 targets configured)

Analyzing: target //:license-check (168 packages loaded, 3497 targets configured)

Analyzing: target //:license-check (168 packages loaded, 3497 targets configured)

Analyzing: target //:license-check (168 packages loaded, 3497 targets configured)

Analyzing: target //:license-check (172 packages loaded, 5510 targets configured)

Analyzing: target //:license-check (175 packages loaded, 5646 targets configured)
[11 / 17] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local ... (2 actions, 1 running)
Analyzing: target //:license-check (199 packages loaded, 5722 targets configured)
[13 / 17] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions, 1 running)
Analyzing: target //:license-check (199 packages loaded, 5722 targets configured)
[13 / 17] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 1s disk-cache, processwrapper-sandbox ... (2 actions running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 66 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
Analyzing: target //:license-check (199 packages loaded, 5722 targets configured)
[15 / 17] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
Analyzing: target //:license-check (199 packages loaded, 5722 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (200 packages loaded, 10056 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (200 packages loaded, 10056 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (200 packages loaded, 10056 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (200 packages loaded, 10056 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (200 packages loaded, 10056 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (200 packages loaded, 10056 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (200 packages loaded, 10056 targets configured)
[17 / 17] no actions running
INFO: Analyzed target //:license-check (202 packages loaded, 10170 targets configured).
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 52.005s, Critical Path: 4.74s
INFO: 17 processes: 12 internal, 4 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 17 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

src/rust/rust_kvs_tool/BUILD

MODULE.bazel

src/rust/rust_kvs/Cargo.toml

tests/test_cases/config/logging.json

BUILD

arkjedrz · 2026-02-16T09:26:27Z

Waiting for build fixes for logging deps.

github-actions · 2026-02-18T10:55:56Z

The created documentation from the pull request is available at: docu-html

MODULE.bazel

tests/test_scenarios/rust/Cargo.toml

pawelrutkaq · 2026-02-19T15:18:25Z

tests/test_cases/config/logging.json

@@ -0,0 +1,7 @@
+{
+    "appId": "RUTS",


Replaced with TEST.

pawelrutkaq · 2026-02-19T15:18:32Z

tests/test_cases/config/logging.json

+    "logMode": "kConsole",
+    "logLevel": "kVerbose",
+    "logLevelThresholdConsole": "kInfo"
+}


last line empty missing

Result of VS Code format. I see it's common for JSON files, so I leave it as is.

I wouldn't insist but for completeness this is basically just a matter of configuration if you enable
"files.insertFinalNewline": true and
"files.trimFinalNewlines": true also after format there is "exactly" one newline

MODULE.bazel

src/rust/rust_kvs/src/json_backend.rs

- Use `stdout_logger` for Cargo builds. - Use `score_log_bridge` for Bazel builds. - Additional logs from Rust implementation. - Use proxy module for logging with correct context across the lib. - Fix tests.

arkjedrz marked this pull request as draft January 7, 2026 15:01

arkjedrz requested a review from pawelrutkaq January 7, 2026 15:01

arkjedrz force-pushed the arkjedrz_enable-logging-2 branch from 77bc368 to d9faad5 Compare January 7, 2026 15:06

pawelrutkaq reviewed Jan 7, 2026

View reviewed changes

src/rust/rust_kvs_tool/BUILD Outdated Show resolved Hide resolved

MODULE.bazel Show resolved Hide resolved

arkjedrz force-pushed the arkjedrz_enable-logging-2 branch 5 times, most recently from b065c66 to ba914d3 Compare January 8, 2026 09:55

arkjedrz requested a review from vinodreddy-g January 8, 2026 13:53

arkjedrz self-assigned this Jan 12, 2026

arkjedrz force-pushed the arkjedrz_enable-logging-2 branch 2 times, most recently from 3594ed5 to 18dc8b8 Compare January 15, 2026 08:19

arkjedrz mentioned this pull request Jan 15, 2026

rust_kvs: integrate S-CORE logging qorix-group/persistency#33

Closed

vinodreddy-g reviewed Jan 16, 2026

View reviewed changes

src/rust/rust_kvs/Cargo.toml Outdated Show resolved Hide resolved

arkjedrz force-pushed the arkjedrz_enable-logging-2 branch from 18dc8b8 to c2eabd7 Compare January 19, 2026 13:48

arkjedrz requested review from pawelrutkaq and vinodreddy-g January 19, 2026 13:51

arkjedrz force-pushed the arkjedrz_enable-logging-2 branch 5 times, most recently from ac5219a to d110ca3 Compare January 23, 2026 08:12

arkjedrz marked this pull request as ready for review January 23, 2026 08:13

PiotrKorkus reviewed Jan 27, 2026

View reviewed changes

tests/test_cases/config/logging.json Show resolved Hide resolved

BUILD Outdated Show resolved Hide resolved

arkjedrz force-pushed the arkjedrz_enable-logging-2 branch from d110ca3 to d4b1afa Compare January 27, 2026 14:32

arkjedrz force-pushed the arkjedrz_enable-logging-2 branch from d4b1afa to 7e3f55c Compare February 18, 2026 10:45

arkjedrz requested a review from PandaeDo as a code owner February 18, 2026 10:45

arkjedrz force-pushed the arkjedrz_enable-logging-2 branch 2 times, most recently from 03b3814 to fbc0f33 Compare February 19, 2026 15:00

pawelrutkaq requested changes Feb 19, 2026

View reviewed changes

umaucher previously approved these changes Feb 19, 2026

View reviewed changes

arkjedrz dismissed umaucher’s stale review via 658d775 February 20, 2026 07:34

arkjedrz force-pushed the arkjedrz_enable-logging-2 branch from fbc0f33 to 658d775 Compare February 20, 2026 07:34

impl: use score_log for logs

a2328f0

- Use `stdout_logger` for Cargo builds. - Use `score_log_bridge` for Bazel builds. - Additional logs from Rust implementation. - Use proxy module for logging with correct context across the lib. - Fix tests.

arkjedrz force-pushed the arkjedrz_enable-logging-2 branch from 658d775 to a2328f0 Compare February 20, 2026 08:32

arkjedrz requested a review from pawelrutkaq February 20, 2026 08:38

pawelrutkaq approved these changes Feb 23, 2026

View reviewed changes

vinodreddy-g approved these changes Feb 24, 2026

View reviewed changes

vinodreddy-g merged commit b9420a2 into eclipse-score:main Feb 24, 2026
17 checks passed

arkjedrz deleted the arkjedrz_enable-logging-2 branch February 24, 2026 07:08

Conversation

arkjedrz commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arkjedrz commented Feb 16, 2026

Uh oh!

github-actions bot commented Feb 18, 2026

Uh oh!

Uh oh!

Uh oh!

pawelrutkaq Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

arkjedrz Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

pawelrutkaq Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

arkjedrz Feb 20, 2026

Choose a reason for hiding this comment

Uh oh!

umaucher Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

arkjedrz commented Jan 7, 2026 •

edited

Loading

github-actions bot commented Jan 7, 2026 •

edited

Loading

umaucher Feb 20, 2026 •

edited

Loading