Fixes persistency test_scenarios integration in reference_integration by rmaddikery · Pull Request #228 · eclipse-score/persistency

rmaddikery · 2026-01-22T14:00:01Z

Fixes persistency test_scenarios integration in reference_integration as a prerequisite to integrate datarouter to the reference integration platform

Refer: eclipse-score/reference_integration#79

NOTE:
mw/log frontend is part of the https://github.com/eclipse-score/baselibs repo
mw/log recorders and respective concrete backends are part of https://github.com/eclipse-score/logging repo
That said, the mw/log:log target is no longer supported in the baselibs and requires to be fixed.
See: https://github.com/eclipse-score/baselibs/blob/381dd9a9c9c516d87b0840f61618ba9e668dabd5/score/mw/log/BUILD#L25

In order to integrate datarouter to the reference integration platform, the deps in image need to be fixed as a prerequisite.

TRLC dep could be excluded via:
The CI build jobs will be fixed after eclipse-score/communication#143
But it might be useful to retain incase tests or implementations in persistency repo need to refer AoUs and requirements coming from baselibs and logging repo.

github-actions · 2026-01-22T14:01:04Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 7c92e2f6-cd22-4476-bc37-95e919511da8
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.8.3 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.2, but got rules_cc@0.2.16 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0.bcr.1, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'google_benchmark', the root module requires module version google_benchmark@1.9.4, but got google_benchmark@1.9.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_process', the root module requires module version score_process@1.4.0, but got score_process@1.4.3 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.10.2, but got aspect_rules_lint@2.0.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 1 packages loaded
Loading: 1 packages loaded
    currently loading: 
Loading: 1 packages loaded
    currently loading: 
Loading: 1 packages loaded
    currently loading: 
Analyzing: target //:license-check (2 packages loaded, 0 targets configured)
Analyzing: target //:license-check (2 packages loaded, 0 targets configured)

Analyzing: target //:license-check (66 packages loaded, 10 targets configured)

Analyzing: target //:license-check (71 packages loaded, 10 targets configured)

Analyzing: target //:license-check (84 packages loaded, 10 targets configured)

Analyzing: target //:license-check (138 packages loaded, 814 targets configured)

Analyzing: target //:license-check (149 packages loaded, 2900 targets configured)

Analyzing: target //:license-check (156 packages loaded, 3364 targets configured)

Analyzing: target //:license-check (161 packages loaded, 3413 targets configured)

Analyzing: target //:license-check (161 packages loaded, 3413 targets configured)

Analyzing: target //:license-check (165 packages loaded, 5426 targets configured)

Analyzing: target //:license-check (168 packages loaded, 5562 targets configured)
[6 / 17] [Prepa] Creating source manifest for @@score_tooling+//dash/tool/formatters:dash_format_converter [for tool] ... (2 actions, 1 running)
Analyzing: target //:license-check (189 packages loaded, 5630 targets configured)
[13 / 17] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions, 1 running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 62 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
Analyzing: target //:license-check (192 packages loaded, 5638 targets configured)
[15 / 17] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
Analyzing: target //:license-check (192 packages loaded, 5638 targets configured)
[16 / 17] [Prepa] Building license.check.license_check.jar ()
Analyzing: target //:license-check (192 packages loaded, 5638 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (193 packages loaded, 5638 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (193 packages loaded, 9972 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (193 packages loaded, 9972 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (193 packages loaded, 9972 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (193 packages loaded, 9972 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (193 packages loaded, 9972 targets configured)
[17 / 17] no actions running
Analyzing: target //:license-check (193 packages loaded, 9972 targets configured)
[17 / 17] no actions running
INFO: Analyzed target //:license-check (195 packages loaded, 10086 targets configured).
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 43.268s, Critical Path: 4.14s
INFO: 17 processes: 12 internal, 4 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 17 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2026-02-11T12:19:52Z

The created documentation from the pull request is available at: docu-html

- library targets should depend on the log frontend to limit lib dep footprint. - while test targets need to proivide concrete backends. For unit tests a lightweight console recorder with console logging backend is sufficient. - for a binary target a log target that includes all backends is ideal.

- v2.0.0 is not compatible with bazel v8 and earlier - Issue filed: github.com/aspect-build/rules_lint/issues/759

vinodreddy-g · 2026-02-12T14:45:46Z

MODULE.bazel


 # ToDo: implicit dependencies for score_tooling, but needed directly here??
-bazel_dep(name = "aspect_rules_lint", version = "2.0.0")
+bazel_dep(name = "aspect_rules_lint", version = "1.10.2")


why was the version downgraded?

vinodreddy-g · 2026-02-12T14:47:50Z

MODULE.bazel


+# Override score_docs_as_code to resolve compatibility level conflicts between dependencies
 bazel_dep(name = "score_docs_as_code", version = "3.0.0", dev_dependency = True)
+single_version_override(


why do we need single_version_override here?

moreover it cannot be used. The only place where it should be used is reference_integration repo

vinodreddy-g · 2026-02-12T14:59:18Z

tests/test_scenarios/cpp/BUILD

    visibility = ["//visibility:public"],
    deps = [
        "//src/cpp/src:kvs_cpp",
+        "@score_logging//score/mw/log",


why is this required for test_scenarios ? I dont see any tests added . It is becuase the kremotelogging=false is removed?

becasue you use mw/log under the hood. Check:

bazel query "kind('cc_library', deps(//tests/test_scenarios/cpp:test_scenarios))" --keep_going | grep "mw/log"

PiotrKorkus · 2026-02-12T15:03:36Z

MODULE.bazel

+)
+
+# TRLC required transitively via: score_logging -> score_communication -> trlc
+bazel_dep(name = "trlc", version = "0.0.0")


dev_dependency? I dont want every repo that uses persistency to be obliged to load trlc especially when it is not using it

pawelrutkaq · 2026-02-19T15:23:38Z

To me this PR looks obsolete and not needed or ? Or at least it's not clear what it tries to really do - not from code and not from Pr desc.

rmaddikery · 2026-02-19T15:48:45Z

changes here are no longer required after bump to baselibs 0.2.4
however, there is still one issue:

persistency/tests/test_scenarios/cpp/BUILD

Line 30 in 69bbb52

"@score_baselibs//score/mw/log:backend_stub_testutil",

A binary target should not dep on a test_only target!

rmaddikery changed the title ~~Rama fix log target deps~~ Fix log target deps Jan 22, 2026

rmaddikery mentioned this pull request Jan 26, 2026

Bumps score baselibs and communication deps eclipse-score/logging#40

Closed

10 tasks

rmaddikery marked this pull request as draft January 29, 2026 13:20

rmaddikery force-pushed the rama_fix_logging_deps branch 4 times, most recently from f3a9506 to 596a4f2 Compare February 11, 2026 12:11

rmaddikery changed the title ~~Fix log target deps~~ Fixes persistency test_scenarios integration in reference_integration Feb 11, 2026

rmaddikery marked this pull request as ready for review February 11, 2026 12:38

rmaddikery requested review from PandaeDo and vinodreddy-g as code owners February 11, 2026 12:38

rmaddikery force-pushed the rama_fix_logging_deps branch 2 times, most recently from 3eb6366 to 43d3910 Compare February 11, 2026 12:56

PandaeDo requested a review from pawelrutkaq February 11, 2026 13:27

rmaddikery force-pushed the rama_fix_logging_deps branch from 73648e6 to d1ad72d Compare February 11, 2026 14:13

rmaddikery marked this pull request as draft February 11, 2026 16:43

rmaddikery force-pushed the rama_fix_logging_deps branch 2 times, most recently from 0bceb88 to cdc65a7 Compare February 11, 2026 17:24

rmaddikery and others added 5 commits February 12, 2026 13:51

Removes deprecated feature flag in mw/log

e6e6490

Fix: Use v1.10.2 for aspect_rules_lint

ea41063

- v2.0.0 is not compatible with bazel v8 and earlier - Issue filed: github.com/aspect-build/rules_lint/issues/759

Fixes starlark buildifier formatting

eede0ab

Fixes documentation generation for score_process dep

c26079f

rmaddikery force-pushed the rama_fix_logging_deps branch from cdc65a7 to c26079f Compare February 12, 2026 12:52

rmaddikery marked this pull request as ready for review February 12, 2026 14:12

FScholPer previously approved these changes Feb 12, 2026

View reviewed changes

vinodreddy-g requested changes Feb 12, 2026

View reviewed changes

PiotrKorkus reviewed Feb 12, 2026

View reviewed changes

arkjedrz mentioned this pull request Feb 16, 2026

chore: Update baselibs commit #175

Closed

Fix module deps after baselibs new release 0.2.4

600468f

rmaddikery dismissed FScholPer’s stale review via 600468f February 19, 2026 14:28

rmaddikery closed this Feb 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes persistency test_scenarios integration in reference_integration#228

Fixes persistency test_scenarios integration in reference_integration#228
rmaddikery wants to merge 6 commits intoeclipse-score:mainfrom
rmaddikery:rama_fix_logging_deps

rmaddikery commented Jan 22, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

vinodreddy-g Feb 12, 2026

Uh oh!

vinodreddy-g Feb 12, 2026

Uh oh!

PiotrKorkus Feb 12, 2026

Uh oh!

vinodreddy-g Feb 12, 2026

Uh oh!

rmaddikery Feb 19, 2026

Uh oh!

PiotrKorkus Feb 12, 2026

Uh oh!

rmaddikery Feb 19, 2026

Uh oh!

pawelrutkaq commented Feb 19, 2026 •

edited

Loading

Uh oh!

rmaddikery commented Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

rmaddikery commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

vinodreddy-g Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

vinodreddy-g Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

PiotrKorkus Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

vinodreddy-g Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

rmaddikery Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

PiotrKorkus Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

rmaddikery Feb 19, 2026

Choose a reason for hiding this comment

Uh oh!

pawelrutkaq commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rmaddikery commented Feb 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rmaddikery commented Jan 22, 2026 •

edited

Loading

github-actions bot commented Jan 22, 2026 •

edited

Loading

pawelrutkaq commented Feb 19, 2026 •

edited

Loading