-
Notifications
You must be signed in to change notification settings - Fork 67
[1865] Fix focus loss on some characters in the text import modal #1873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AxelRICHARD
reviewed
Jan 20, 2026
frontend/syson-components/src/extensions/InsertTextualSysMLv2Modal.tsx
Outdated
Show resolved
Hide resolved
Member
|
A playwright test could be a good idea, in order to avoid regression. |
ee7d979 to
057ebe3
Compare
Contributor
Author
Will do. |
057ebe3 to
8f554b3
Compare
AxelRICHARD
reviewed
Jan 21, 2026
integration-tests-cypress/cypress/e2e/project/explorer/insertTextualSysMLv2Tests.cy.ts
Show resolved
Hide resolved
8f554b3 to
5a3d078
Compare
AxelRICHARD
reviewed
Jan 21, 2026
e4daf53 to
9510418
Compare
Bug: #1865 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
9510418 to
8049dc1
Compare
AxelRICHARD
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See eclipse-sirius/sirius-web@58156cd for the equivalent fix in Sirius Web.
Bug: #1865
Signed-off-by: Pierre-Charles David pierre-charles.david@obeo.fr
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Auto review
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc?CHANGELOG.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests