Skip to content

Conversation

@pcdavid
Copy link
Contributor

@pcdavid pcdavid commented Jan 20, 2026

See eclipse-sirius/sirius-web@58156cd for the equivalent fix in Sirius Web.

Bug: #1865
Signed-off-by: Pierre-Charles David pierre-charles.david@obeo.fr

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@AxelRICHARD
Copy link
Member

A playwright test could be a good idea, in order to avoid regression.

@pcdavid pcdavid force-pushed the pcd/fix/text-import-focus branch from ee7d979 to 057ebe3 Compare January 20, 2026 16:31
@pcdavid
Copy link
Contributor Author

pcdavid commented Jan 20, 2026

A playwright test could be a good idea, in order to avoid regression.

Will do.
Actually, I see that there is an existing Cypress test for this modal, but no Playwright test. Should I take the time to port the existing test to PW and then extend it?

@pcdavid pcdavid force-pushed the pcd/fix/text-import-focus branch from 057ebe3 to 8f554b3 Compare January 21, 2026 14:07
@pcdavid pcdavid force-pushed the pcd/fix/text-import-focus branch from 8f554b3 to 5a3d078 Compare January 21, 2026 15:04
@pcdavid pcdavid force-pushed the pcd/fix/text-import-focus branch 2 times, most recently from e4daf53 to 9510418 Compare January 22, 2026 09:25
Bug: #1865
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@AxelRICHARD AxelRICHARD force-pushed the pcd/fix/text-import-focus branch from 9510418 to 8049dc1 Compare January 22, 2026 10:13
@AxelRICHARD AxelRICHARD merged commit b628d3c into main Jan 22, 2026
4 checks passed
@AxelRICHARD AxelRICHARD deleted the pcd/fix/text-import-focus branch January 22, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In the "New objects from text modal", some texts can not be entered

3 participants