[1861] Split responsibilities of SysONLibraryPublicationHandler #1874
Conversation
flatombe
force-pushed
the
dev/FLA/refactor-publication
branch
from
35379e7 to
6a6350f
Compare
| .toList(); | ||
| } | ||
|
|
||
| protected Optional<SemanticData> publishAsLibrary(final ICause parentCause, final Collection<Resource> resources, final String libraryNamespace, final String libraryName, |
There was a problem hiding this comment.
Why some methods here are protected and some others private?
There was a problem hiding this comment.
For some reasons SysONLibraryPublicationHandler had a single private method but I missed it.
Fixed by setting the private ones to protected so downstream applications can easily fork the SysON default implementation to suit their own needs.
| .formatted(libraryMetadataAdapter.getNamespace(), libraryMetadataAdapter.getName(), | ||
| libraryMetadataAdapter.getVersion()))); | ||
| }); | ||
| // Ignore the resource if it isn't a library: all non-library resources are published in a single |
There was a problem hiding this comment.
Why this comment is here, not attached to anything?
There was a problem hiding this comment.
Fixed by rewording the comment and moving it before the call to getLibraryMetadata(Resource).ifPresent(...) which is the subject for that comment.
| result = new ErrorPayload(cause.id(), | ||
| List.of(new Message("Cannot publish SysML library from editing context '%s'.".formatted(libraryAuthoringEditingContext.getId()), MessageLevel.ERROR))); | ||
| } else if (this.librarySearchService.findByNamespaceAndNameAndVersion(libraryNamespace, libraryName, libraryVersion).isPresent()) { | ||
| // Sirius Web works assumes that published libraries are immutable. |
There was a problem hiding this comment.
A bit of both I guess :-) Fixed by rewording that comment.
|
|
||
| final Optional<SemanticData> maybePublishedLibrarySemanticData = this.publishAsLibrary(cause, resourcesToPublish, libraryNamespace, libraryName, libraryVersion, libraryDescription, | ||
| dependencies); | ||
| // After this transaction is done, SysONLibraryPublicationListener reacts by also creating the |
There was a problem hiding this comment.
Is this comments till true?
There was a problem hiding this comment.
Yes that is still the case.
| return result; | ||
| } | ||
|
|
||
| private IPayload doPublish(final ICause cause, final IEMFEditingContext emfEditingContext, final String libraryNamespace, final String libraryName, |
There was a problem hiding this comment.
Could you please describe in the javadoc what this method does?
There was a problem hiding this comment.
Fixed by adding Javadoc to that method.
Bug: eclipse-syson#1861 Signed-off-by: Florent Latombe <florent.latombe@obeo.fr>
flatombe
force-pushed
the
dev/FLA/refactor-publication
branch
from
6a6350f to
3b44578
Compare
2 participants
Bug: #1861
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Auto review
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc?CHANGELOG.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests