Provide a C++ compatible macro definition for UX_NULL#97
Open
aerisnju wants to merge 1 commit intoeclipse-threadx:masterfrom
Open
Provide a C++ compatible macro definition for UX_NULL#97aerisnju wants to merge 1 commit intoeclipse-threadx:masterfrom
aerisnju wants to merge 1 commit intoeclipse-threadx:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a macro stands for null pointers. i.e.
UX_NULL. Currently its definition isIt works perfectly for C projects. But when it comes to C++, we will get compilation errors because
((void*)0)is not allowed in C++ as a null pointer [1]. Instead,0ornullptrare allowed. So we need to change the macro definition in C++.In the PR I use the presence of macro
__cplusplusto distinguish C and C++ environments. We will still get the original definitions when we compile C sources. For maximum compability, I choose to use0as the definition instead ofnullptrbecause the latter requires c++11 or later.[1] https://en.cppreference.com/w/cpp/types/NULL