Use an exception to indicate validation errors#189
Merged
sophokles73 merged 1 commit intoeclipse-uprotocol:mainfrom Sep 4, 2025
Merged
Conversation
Replaced ValidationResult with a Java runtime exception that is being thrown in case of validation errors. This is more in line with the principles of exception handling in Java and allows for better error propagation and usage of existing tooling around exceptions, e.g. in unit tests.
|
Code coverage report is ready! 📈
|
Contributor
Author
|
@PLeVasseur would you mind taking a look? |
PLeVasseur
approved these changes
Sep 4, 2025
PLeVasseur
left a comment
PLeVasseur
left a comment
There was a problem hiding this comment.
LGTM. Seems this is intended to use the more "native" way of signaling errors, exceptions, in Java.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced ValidationResult with a Java runtime exception that is being
thrown in case of validation errors. This is more in line with the
principles of exception handling in Java and allows for better error
propagation and usage of existing tooling around exceptions, e.g. in
unit tests.