Skip to content

Initial commit for updating vsomeip python transport to 1.5.8 release#7

Open
DivyaVuppala wants to merge 2 commits intoeclipse-uprotocol:mainfrom
DivyaVuppala:communication-layer-changes
Open

Initial commit for updating vsomeip python transport to 1.5.8 release#7
DivyaVuppala wants to merge 2 commits intoeclipse-uprotocol:mainfrom
DivyaVuppala:communication-layer-changes

Conversation

@DivyaVuppala
Copy link
Contributor

No description provided.

@DivyaVuppala DivyaVuppala force-pushed the communication-layer-changes branch 4 times, most recently from 4270457 to 9e8423f Compare August 14, 2024 14:22
@DivyaVuppala DivyaVuppala force-pushed the communication-layer-changes branch from 9e8423f to 7d9124a Compare August 14, 2024 14:24
event_id: int,
data: bytearray,
request_id: int,
_: int,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this and why isn't it being used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Underlying Vsomeip python library callbacks have a callback method definition, one of the attributes is request_id = client+session_id
In case of event handling we don't do anything with this attribute as all we need is service_id, instance_id, event_id data, message_type

def _on_service_sending_response_handler(
self,
message_type: int,
_: int,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question here, what's going on with these underscores

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an extra callback we register to service to save the umessage responses data based on clientid+sessionid
we don't need the other attributes are hence not named

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is really big... can you separate all those handlers into their own package/file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants