updated to ZenohUTranspoart, updated signature, fixed dependencies and added clang-format.sh#28
Conversation
PLeVasseur
left a comment
PLeVasseur
left a comment
There was a problem hiding this comment.
Hey @MaximilianToe -- thanks for updating this! Left a few comments and questions.
| void notifyListener(const v1::UMessage& message); | ||
| void listenThread(); // listen for incoming messages (thread) | ||
| void cleanupListener(CallableConn listener) override {} | ||
| void cleanupListener(const CallableConn& listener) override {} |
There was a problem hiding this comment.
Is this file needed anymore, now that we're using the Zenoh transport? 🤔 I'm in favor of mercilessly cutting out code to make a more maintainable codebase.
There was a problem hiding this comment.
@MaximilianToe and I chatted.
Plan is:
- merge this
- he'll open another PR tackling
pubsub - can then remove all traces of the socket transport from this repo
Lemme know if I got anything mixed Max!
| @@ -24,17 +24,18 @@ | |||
| #include <spdlog/spdlog.h> | |||
There was a problem hiding this comment.
I see a client and server for rpc. Am I missing where the source is for the publisher and subscriber in pubsub?
PLeVasseur
left a comment
PLeVasseur
left a comment
There was a problem hiding this comment.
Thanks for the quick turn-around and flexibility @MaximilianToe!
| void notifyListener(const v1::UMessage& message); | ||
| void listenThread(); // listen for incoming messages (thread) | ||
| void cleanupListener(CallableConn listener) override {} | ||
| void cleanupListener(const CallableConn& listener) override {} |
There was a problem hiding this comment.
@MaximilianToe and I chatted.
Plan is:
- merge this
- he'll open another PR tackling
pubsub - can then remove all traces of the socket transport from this repo
Lemme know if I got anything mixed Max!
2 participants
This PR targets the following issues:
Closes #23 #24 #25 #27