-
Notifications
You must be signed in to change notification settings - Fork 49
log timings for different sections of training/inference loop #1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@grassesi : could you give an example of what is logged and how one can access it (will it be on MLflow or plot_train)? |
| "weathergen-evaluate", | ||
| "weathergen-readers-extra" | ||
| "weathergen-readers-extra", | ||
| "pyarrow>=22.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep all our packages at the bottom
|
As discussed with @grassesi , this draft is great to understand the general scope of writing timers. We should have a quick design session before starting implementing our own implementation. A good example of all the subtleties to deal with is src/nanotron/logging/timers.py in nanotron. Maybe we should consider copy/pasting their implementation (or another one). |

Description
Small utility to record timings, recorded timings will be logged into to the metrics file.
Issue Number
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60