-
Notifications
You must be signed in to change notification settings - Fork 15
Add more test specific to end-to-end scenarios #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
marcosbento
wants to merge
7
commits into
develop
Choose a base branch
from
feature/more_tests
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88b3ea8 to
f47eb21
Compare
This change is part of reorganising existing tests, to allow the creation of a more effective end-to-end testing capability.
f47eb21 to
0107232
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #254 +/- ##
===========================================
+ Coverage 48.77% 49.11% +0.34%
===========================================
Files 1224 1228 +4
Lines 96060 96730 +670
Branches 14835 14875 +40
===========================================
+ Hits 46851 47513 +662
- Misses 49209 49217 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2df41f1 to
52b9823
Compare
a374770 to
1dbf2a2
Compare
The goal of these is to, eventually, drive end-to-end tests capable of: - provisioning configuration files - such as server environment files or password/whitelist files - launching the ecflow server - executing a sequence of ecflow client commands - and, ensure the corresponding expected outcome. These tests will make use of the ecflow server and client executables, and thus will avoid using API mocks (used by other more limited tests).
The Process class wraps the OS capability to launch, wait for completion or terminate an Operating System child process. This class also captures the stdout/stderr, enabling the verification of expected outputs.
Re ECFLOW-2057
32519b3 to
e744c27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is part of reorganising existing tests, to allow the creation of a more effective end-to-end testing capability.
Description
Group existing tests in specific directory
Contributor Declaration
By opening this pull request, I affirm the following:
🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-254