Skip to content

Conversation

@marcosbento
Copy link
Collaborator

@marcosbento marcosbento commented Dec 18, 2025

This change is part of reorganising existing tests, to allow the creation of a more effective end-to-end testing capability.

Description

Group existing tests in specific directory

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/ecflow/pull-requests/PR-254

This change is part of reorganising existing tests, to allow the
creation of a more effective end-to-end testing capability.
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 94.91279% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.11%. Comparing base (df284e4) to head (e744c27).

Files with missing lines Patch % Lines
libs/test/foolproof/scaffold/Provisioning.hpp 93.04% 21 Missing ⚠️
libs/test/foolproof/TestFoolproof.cpp 98.10% 6 Missing ⚠️
libs/test/foolproof/scaffold/Process.cpp 90.69% 4 Missing ⚠️
...ibs/server/src/ecflow/server/ServerEnvironment.cpp 50.00% 3 Missing ⚠️
libs/test/overall/harness/TestFixture.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #254      +/-   ##
===========================================
+ Coverage    48.77%   49.11%   +0.34%     
===========================================
  Files         1224     1228       +4     
  Lines        96060    96730     +670     
  Branches     14835    14875      +40     
===========================================
+ Hits         46851    47513     +662     
- Misses       49209    49217       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcosbento marcosbento force-pushed the feature/more_tests branch 2 times, most recently from 2df41f1 to 52b9823 Compare December 21, 2025 06:56
@marcosbento marcosbento force-pushed the feature/more_tests branch 4 times, most recently from a374770 to 1dbf2a2 Compare January 3, 2026 10:50
@marcosbento marcosbento changed the title Group existing tests in specific directory Add more test specific to end-to-end scenarios Jan 3, 2026
The goal of these is to, eventually, drive end-to-end tests capable of:
 - provisioning configuration files
   - such as server environment files or password/whitelist files
 - launching the ecflow server
 - executing a sequence of ecflow client commands
   - and, ensure the corresponding expected outcome.

These tests will make use of the ecflow server and client executables,
and thus will avoid using API mocks (used by other more limited tests).
The Process class wraps the OS capability to launch, wait for completion
or terminate an Operating System child process. This class also captures
the stdout/stderr, enabling the verification of expected outputs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants