Remove deprecated BaseOption::setDefaultValue() ECKIT-650 #248
+7
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR removes the deprecated BaseOption::setDefaultValue() method and updates code to specify default values via constructor parameters instead of the deprecated fluent API method.
Changes:
- Removed deprecated
BaseOption::setDefaultValue()method from Option.h - Updated BaseOption constructor to use forwarding reference (
T&&) instead of const lvalue reference (const T&) - Fixed incorrect base class constructor call in VectorOption.cc
- Updated test to use constructor-based default value specification with C++17 CTAD
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/eckit/option/Option.h | Removes deprecated defaultValue() method and changes constructor parameter from const T& to T&& |
| src/eckit/option/VectorOption.cc | Fixes incorrect base constructor call that was wrapping parameters in non-existent Option() constructor |
| tests/option/eckit_test_option_cmdargs.cc | Updates test to use constructor-based default values with CTAD instead of deprecated defaultValue() method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #248 +/- ##
===========================================
- Coverage 66.25% 66.22% -0.03%
===========================================
Files 1131 1131
Lines 57959 57952 -7
Branches 4394 4394
===========================================
- Hits 38398 38380 -18
- Misses 19561 19572 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marcosbento
force-pushed
the
feature/remove_deprecated_baseoption_default_value
branch
from
22a7e43 to
b61312d
Compare
Re ECKIT-650
This change takes the default value by value and moves it into the optional data member. Re ECKIT-650
marcosbento
force-pushed
the
feature/remove_deprecated_baseoption_default_value
branch
from
b61312d to
83b5e6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement changes requested by https://jira.ecmwf.int/browse/ECKIT-650.
Contributor Declaration
By opening this pull request, I affirm the following:
🌦️ >> Documentation << 🌦️
https://sites.ecmwf.int/docs/dev-section/eckit/pull-requests/PR-248