charretto F3 design #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storbook lib and related peer-dependecies to it has been upgraded in package.json storybook knob has been deleted from the project in packages.json and storybook/main.js This push contains the Charretto Feature user story 3 as a library of components and contains thier complete web page It also contains Testimonial Slider two components .. Slider and Review Card
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
storybook lib and related peer-dependecies to it has been upgraded in package.json
storybook knob has been deleted from the project in packages.json and storybook/main.js
This push contains the Charretto Feature user story No:3 as a library of components and contains their complete web page
It also contains Testimonial Slider components .. Slider and Review Card
@tro9999 Can you point out about if I had used a correct way to use chakra UI and Styled-components libs together .. Please check this file as a reference first: TitleDescription_InputExpandableCard.js
Here is a quick loom for it as well: https://www.loom.com/share/e8e1f6ff487a43a89a39224ed61908f4
Chromatic link for TitleDescription_InputExpandableCard.js component: https://www.chromatic.com/component?appId=617153c21240d3003a0a1899&name=Charretto%20F3%2FTitle%20Description%20Input%20Expandable%20Card&buildNumber=1&componentInspectorKey=617155148b36cb004aad6831-1200-interactive-true&historyLengthAtIndex=3&distanceToMoveBack=-1
Here is chromatic link for the whole lib as well: https://www.chromatic.com/library?appId=617153c21240d3003a0a1899
CC @valto