Separate event date and time copying#572
Open
vishwasja wants to merge 2 commits intoedbirmingham:masterfrom
Open
Separate event date and time copying#572vishwasja wants to merge 2 commits intoedbirmingham:masterfrom
vishwasja wants to merge 2 commits intoedbirmingham:masterfrom
Conversation
- Replaced scheduled_at datetime field with seperate date and time field - Added changes in controller to join date and time in controller to save as scheduled_at
Contributor
|
@vishwasja There is a failing test on Travis CI. |
- Replaced scheduled_at with scheduled_at_date and scheduled_at_time
Contributor
Author
|
@anthonycrumley Fixed failing tests. |
anthonycrumley
requested changes
Dec 6, 2017
Contributor
anthonycrumley
left a comment
anthonycrumley
left a comment
There was a problem hiding this comment.
Thanks for this change and sorry for the delay. Please see comment about scheduled at time editing.
| </div> | ||
| <div class="col-sm-6" style="padding-right: 0;"> | ||
| <div class="input-group date" id="event-timepicker"> | ||
| <input type='text' class="form-control" name="network_event[scheduled_at_time]" id="network_event_scheduled_at" value="<%= @network_event.scheduled_at %>" /> |
Contributor
There was a problem hiding this comment.
@vishwasja This time value does not seem to be working correctly. An event created with a scheduled time of 11:00am is showing as 8:00pm when edited.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In copy event if the scheduled_at date and time BOTH are provided ONLY then the scheduled_at is update for the copied events.
Ticket #545