Open
Conversation
…d do not run in older browsers. There is still a case in developement, because `webpack-dev-server` dropped support for these browsers, that do not support Let/Const declarations. If You want to check validity of these browser, run `yarn build` and run server or index.html manually within this browser. I dont see which data were not loading, im using macOSX without IE, have no machine to test ie and do not want to do it. I used: https://caniuse.com/ Issue could be within IE11 also with partial support for flex, but it depends of implementation. TL:DR; I am Not willing to debug IE11 in this task, its my guess, maybe im wrong. Have no machine to do so. Data works properly in Chrome/Safari/Firefox, or maybe I'm blind. Which data was not loading? Maybe it should be specified in task more clearly... I dont get, what is 'not fully load data', had no issues within any browser within network or console, did not saw any improper behaviour.
Could you be more specific next time? 1. What is properly, 2. Where does this justify should direct? start, center, end? 3. Should be username underneath the image or beneath? Maybe on the right side, maybe on the left? There is incomplete command to say 'do something' about it :) I do not want to extrapolate form incomplete data. `something` means very little to me
refactored js code, added red borded when user name is invalid in input and when user name is not found.
TODO: move logic from nested functions onto command pattern for each allowed event
Todo: move GithubUser onto entity folder
Test filtering this collections for certain events
TODO: Fill timeline with filtered events, Render everything onto html
…esponse from api, added parser for githubEvent
added method getFilledNode TODO: append this filled node into the timeline object via RENDER method
TODO: add event listeners and handle states
* below 768px: made it 100% (as it was before) * 768-1280px: made it 50% * 1280px and above: made it 30%
I also assume that PROD build have internet connection. Ofc I could seek minified version of bulma, or try to attach compression into compiller, but You've said: `the less, the better`.
updated GithubInput with async() promise, better handler for invalid username. Added babel-polyfill onto webpack and package.json PS. My bad, `du -sh ./dist` went too fast, build is larger then I wrote in previous commit.
…atures # Conflicts: # package.json # src/index.html # yarn.lock
Deleted skeletons from app, moved them onto storage
added timeline special context for review event
set max-width of #profile-bio
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge after #2
Added new features:
Fetch from github for user:
PullRequestEvent- both "opened" and "closed" Pull RequestsPullRequestReviewCommentEventHandled
user not foundresponseHide fake Profile and History fields.
I used skeleton to hide these data
Responsive design of Profile
I used media query and bulma to do the job
Reduced size of the compiled build
removed js source maps for prod
covered classess with tests