Reduce firmware read timeout from 60s to 10s to prevent port breakout failure#12
Merged
PJHsieh merged 1 commit intoedge-core:202311.Xfrom Apr 18, 2025
PJHsieh:Reduce_firmware_read_timeout_from_60s_to_10s_to_prevent_port_breakout_failure
Merged
Reduce firmware read timeout from 60s to 10s to prevent port breakout failure#12PJHsieh merged 1 commit intoedge-core:202311.Xfrom PJHsieh:Reduce_firmware_read_timeout_from_60s_to_10s_to_prevent_port_breakout_failure
PJHsieh merged 1 commit intoedge-core:202311.Xfrom
PJHsieh:Reduce_firmware_read_timeout_from_60s_to_10s_to_prevent_port_breakout_failure
Conversation
…ent port breakout failure Issue: Reading the firmware version on specific CMIS transceivers in xcvrd can take up to 60 seconds, causing delays that lead to port breakout failures. Solution: Reduce the maximum firmware read timeout from 60 seconds to 10 seconds to improve responsiveness and avoid port breakout issues. Note: 1. The firmware read timeout mentioned above is also called CDB which is defined in CMIS. 2. The issue happens under the condition that the xcvr's CDB takes long time to response, and several dynamic port breakout mode commands are issued with a short internal. 3. The CDB timeout 60 seconds will block the xcvrd thread and result in the situation that the work for the previous port breakout mode is not done yet but the new port breakout mode is applied. 4. It takes too much effort and is not worthy to handle such condition. So simply reduce the timeout to a more reasonable value to avoid the error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Reading the firmware version on specific CMIS transceivers in xcvrd can take up to 60 seconds, causing delays that lead to port breakout failures.
Solution:
Reduce the maximum firmware read timeout from 60 seconds to 10 seconds to improve responsiveness and avoid port breakout issues.
Note:
Description
Motivation and Context
How Has This Been Tested?
Additional Information (Optional)