Skip to content

Remove incorrect duplicate batch skipping in ReorgAwareStream #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
incrypto32 wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −7
Open

Remove incorrect duplicate batch skipping in ReorgAwareStream #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/amp/streaming/reorg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,6 @@ def __next__(self) -> ResponseBatch:
# Get next batch from underlying stream
batch = next(self.stream_iterator)

# Note: ranges_complete flag is handled by CheckpointStore in load_stream_continuous
# Check if this batch contains only duplicate ranges
if self._is_duplicate_batch(batch.metadata.ranges):
self.logger.debug(f'Skipping duplicate batch with ranges: {batch.metadata.ranges}')
# Recursively call to get the next non-duplicate batch
return self.__next__()

# Detect reorgs by comparing with previous ranges
invalidation_ranges = self._detect_reorg(batch.metadata.ranges)

Expand Down
Loading