fix: include query parameters in GA4 document location #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reconstruct full URL by combining url and search fields to ensure GA4 receives complete URLs with query parameters (UTMs, GCLID, etc.). Fixes EDGEE-874
Pull Request Test Coverage Report for Build 19767059775Details
💛 - Coveralls |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where query parameters (search params) were not being included in the GA4 document location field. The fix concatenates the base URL with the search string to form the complete URL with query parameters.
Key Changes:
- Modified URL construction in both
page()andGaPayload::new()to include query parameters - Version bumped from 1.2.1 to 1.2.2 across all configuration files
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Updated page() function to concatenate data.url and data.search for the document location |
| src/ga_payload.rs | Updated GaPayload::new() to concatenate page URL and search string from event context |
| Cargo.toml | Version bump to 1.2.2 |
| Cargo.lock | Version bump to 1.2.2 |
| edgee-component.toml | Version bump to 1.2.2 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CLEMENTINATOR
approved these changes
Nov 17, 2025
Member
|
@KokaKiwi @CLEMENTINATOR I'm really not sure about this PR. |
SachaMorard
deleted the
fix/edgee-874-update-ga4-implementation-to-include-full-url-with
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
Reconstruct the full URL by including the "search params" (or query string) into the base URL
Related Issues