Skip to content

fix: fixed search packaging#42

Merged
edinstance merged 1 commit intodevfrom
search-fixes
Nov 3, 2025
Merged

fix: fixed search packaging#42
edinstance merged 1 commit intodevfrom
search-fixes

Conversation

@edinstance
Copy link
Owner

@edinstance edinstance commented Nov 3, 2025

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated deployment service container images to use development versions.
    • Reorganised internal code structure for improved maintainability.
    • Refactored service metrics naming conventions for consistency.

@edinstance edinstance merged commit a65313a into dev Nov 3, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 3, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Container image tags in four Kubernetes service manifests have been updated from latest to dev. Additionally, the search service Java package structure has been comprehensively refactored from aviation.search.* to search.* across all classes and test files.

Changes

Cohort / File(s) Summary
Kubernetes Service Manifests
k8s/aircraft/service.yml, k8s/flights/service.yml, k8s/gateway/service.yml, k8s/search/service.yml
Container image tags updated from latest to dev tag across all four service Deployment specifications.
Search Service Package Refactoring
services/search/src/main/java/search/config/*, services/search/src/main/java/search/consumer/FlightEventConsumer.java, services/search/src/main/java/search/exceptions/*, services/search/src/main/java/search/helpers/SearchHelpers.java, services/search/src/main/java/search/model/FlightDocument.java, services/search/src/main/java/search/resolver/FlightSearchResolver.java, services/search/src/main/java/search/service/*, services/search/src/test/java/search/ApplicationTests.java
Package namespace systematically migrated from aviation.search to search hierarchy. All package declarations and internal imports updated accordingly; no functional or behavioural changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Package refactoring is consistent and repetitive across all search service files with no logic changes
  • Kubernetes manifest updates are straightforward tag modifications
  • Compilation verification and import correctness should be validated to ensure no missed dependencies

Possibly related PRs

Poem

🐰 A rabbit hops through namespaces anew,
From aviation.search to search, spritely and true!
With dev tags replacing the latest old way,
The services bound for a brighter-lit day! 🚀

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch search-fixes

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7967c0a and 72ea5d9.

📒 Files selected for processing (19)
  • k8s/aircraft/service.yml (1 hunks)
  • k8s/flights/service.yml (1 hunks)
  • k8s/gateway/service.yml (1 hunks)
  • k8s/search/service.yml (1 hunks)
  • services/search/src/main/java/search/config/OpenSearchConfig.java (1 hunks)
  • services/search/src/main/java/search/config/SearchLogger.java (1 hunks)
  • services/search/src/main/java/search/config/metrics/graphql/GraphqlMetricsHelpers.java (1 hunks)
  • services/search/src/main/java/search/config/metrics/graphql/GraphqlMetricsInstrumentation.java (2 hunks)
  • services/search/src/main/java/search/consumer/FlightEventConsumer.java (1 hunks)
  • services/search/src/main/java/search/exceptions/DomainException.java (1 hunks)
  • services/search/src/main/java/search/exceptions/ExceptionCategories.java (1 hunks)
  • services/search/src/main/java/search/exceptions/GlobalGraphQlExceptionHandler.java (1 hunks)
  • services/search/src/main/java/search/exceptions/UnauthorizedException.java (1 hunks)
  • services/search/src/main/java/search/helpers/SearchHelpers.java (1 hunks)
  • services/search/src/main/java/search/model/FlightDocument.java (1 hunks)
  • services/search/src/main/java/search/resolver/FlightSearchResolver.java (1 hunks)
  • services/search/src/main/java/search/service/FlightIndexService.java (1 hunks)
  • services/search/src/main/java/search/service/FlightSearchService.java (1 hunks)
  • services/search/src/test/java/search/ApplicationTests.java (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@edinstance edinstance deleted the search-fixes branch November 3, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant