Skip to content

fix: fixed router config#47

Merged
edinstance merged 2 commits intomainfrom
dev
Nov 4, 2025
Merged

fix: fixed router config#47
edinstance merged 2 commits intomainfrom
dev

Conversation

@edinstance
Copy link
Owner

@edinstance edinstance commented Nov 4, 2025

Summary by CodeRabbit

  • Configuration
    • Improved OpenTelemetry endpoint resolution with enhanced environment variable handling and more robust fallback defaults for telemetry exporter connections.

@edinstance edinstance merged commit 1d04520 into main Nov 4, 2025
1 check passed
@coderabbitai
Copy link

coderabbitai bot commented Nov 4, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Configuration syntax for OTLP endpoint resolution was updated across two template variables. The changes migrate from direct variable substitution to explicit environment-based lookups with fallback defaults, altering how missing environment variables are handled.

Changes

Cohort / File(s) Summary
OTLP endpoint template syntax updates
router.yml
Changed OTEL exporter and metrics exporter endpoint templates from implicit variable syntax to explicit env. prefix with :- default fallback syntax (e.g., ${OTEL_EXPORTER_OTLP_ENDPOINT:...}${env.OTEL_EXPORTER_OTLP_ENDPOINT:-...})

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Changes are limited to syntax updates in a single configuration file
  • No logic modifications or structural alterations
  • Straightforward migration of environment variable syntax

Poem

🐰 The endpoints now speak clearer,
With env and dashes drawing nearer,
When variables hide, defaults appear,
Our collectors stand without fear! 📡

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dev

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 50e6afc and e1123d6.

📒 Files selected for processing (1)
  • router.yml (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant