Fixed css styles for uploading state #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neSpecc
reviewed
Nov 24, 2024
Contributor
neSpecc
left a comment
neSpecc
left a comment
There was a problem hiding this comment.
Thanks. Please, increment a patch version
Contributor
Author
|
Done |
neSpecc
approved these changes
Nov 24, 2024
paescuj
added a commit
to directus/directus
that referenced
this pull request
Dec 27, 2024
rijkvanzanten
pushed a commit
to directus/directus
that referenced
this pull request
Jan 6, 2025
* Update editorjs deps
* Necessary style adjustments after update
* Include patch for content wrapping
Upstream still not merged, therefore including it at our side for now
* Sync
* Add comments
* Remove shims for plugins that are now typed
* Update & clean-up image plugin
- Simplify plugin customization
- Don't transform images (otherwise stretch option makes no sense at
all)
- Reuse origin renderSettings logic
- Adjust/enhance image plugin styles
* Few styles fixes & comments
* Don't remove focus border when opening popover
Annoying switch between focus on/off
* Sync
* Remove obsolete image tool style patches
Fixed in editor-js/image#276
* Use popover vars to override
* Remove obsolete @editorjs/paragraph shim
Types fixed in editor-js/paragraph#94
---------
Co-authored-by: Connor Winston <connor@winston.guru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the image at upload time incorrectly shows nodes that should be hidden until the image is uploaded:
This happened because during refactoring, the original “loading” class was renamed to “uploading” in the JS code, but missed in the CSS.
I fixed this problem.