Merged
Conversation
added fixes where optimistic_ptr calls are masquerading as shared_ptr cleaned up cmakepresets.json and related option in the canopy.cmake file
added cmake option CANOPY_DEBUG_DEFAULT_DESTRUCTOR fixed optimistic pointer features on clean up
improved cleanup in synchronous generator to call release_from_service where necessary suppressed one test in optimistic pointers for now
… make them initialise consistently
removed the concept of an interface_stub, now the functionallity is routed via the rpc::base class The registration of stubs is no longer required it is now faster and has one less lookup to do when calling a function
…d destination are the same
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the wrapped object to stub lookup by having the weak pointer inside the rpc::base class, eliminates one lookup table due to the fact that we are exclusively using rpc shared and optimistic pointers rather than std equivelents