Conversation
When an idl has been installed, users of the corresponding package should be able to find the generated headers (or the idl if imported) just by depending on xxx_idl_[host|enclave].
This would happen in a pattern where an (int-based) enum is given a my_enum::MAX value set to MAX_INT.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @lanfeust69, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on improving the usability and robustness of the RPCGenerator when it's installed and used as a CMake package. It addresses how IDL dependencies are discovered and how generated headers are exposed to consuming projects. Additionally, it includes a fix in the JSON schema generator to support larger integer values for enums, enhancing its overall reliability.
Highlights
- CMake Package Integration: Enhanced
cmake/FindRPCGenerator.cmaketo correctly locate IDL dependencies and set up include paths when the RPCGenerator is consumed as an installed CMake package. This ensures that projects linking against the installed package can find necessary generated headers and IDL files by inspecting_hosttarget properties and exposingINSTALL_INTERFACEinclude directories for_idl_hostand_idl_enclavetargets. - JSON Schema Generator Robustness: Updated the
generator/src/json_schema/generator.cppto useint64_tfor enum value handling, replacingint. This change, along with usingstd::stollfor parsing explicit enum values, prevents potential integer overflow issues for large enum values during schema generation, improving the generator's reliability.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request enhances the CMake build process for installed packages and expands the capabilities of the JSON schema generator to handle larger enum values. The CMake changes improve dependency resolution, while the C++ code updates the enum value representation to int64_t and uses std::stoll for parsing. Consider adding similar logic for *_enclave targets and improving the error message.
3 participants
No description provided.