Open
Conversation
efekarakus
reviewed
Oct 4, 2022
Owner
efekarakus
left a comment
efekarakus
left a comment
There was a problem hiding this comment.
Awesome, thank you! Just a question
Author
|
Sorry I totally messed up with branches, because I wanted to switch master to main. so the pull request became invalid. 🤦 That's what happens if an amateur is playing in the pro's sandbox. I learned a lot though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tiny problem with the go-file in the termcolor package determinating the available colors on windows.
Apparently lookupWindows() is missnamed in version_windows.go The "problem is, that the identifier in version.go (non-windows) and version_windows.go (windows terminal cmd and powershell) are NOT the same.
Please see also the open issue