fix: should export sessionStore #21

fengmk2 · 2025-01-21T16:38:36Z

Summary by CodeRabbit

Documentation
- Updated README.md to reflect new Redis package naming from egg-redis to @eggjs/redis
- Updated installation and configuration instructions
Dependencies
- Updated @eggjs/core to version 6.3.1
- Added @eggjs/redis version 3.0.0
- Updated egg to version 4.0.3
- Removed egg-redis package
Type Changes
- Added session store configuration methods to EggCore interface

coderabbitai · 2025-01-21T16:38:44Z

Warning

Rate limit exceeded

@fengmk2 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 26 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 7aefc82 and 72b3ed8.

📒 Files selected for processing (4)

README.md (1 hunks)
package.json (1 hunks)
src/types.ts (1 hunks)
test/fixtures/redis-session/config/plugin.js (1 hunks)

Walkthrough

The pull request introduces updates to the Egg.js session plugin, primarily focusing on migrating from the egg-redis package to @eggjs/redis. This change involves updating documentation, dependencies, type definitions, and configuration files to reflect the new package naming and version. The modifications ensure compatibility with the latest package ecosystem and provide enhanced type support for session store management.

Changes

File	Change Summary
`README.md`	Replaced all references to `egg-redis` with `@eggjs/redis` in installation and configuration instructions
`package.json`	- Updated `@eggjs/core` to `^6.3.1` - Added `@eggjs/redis@^3.0.0` - Updated `egg` to `^4.0.3` - Removed `egg-redis` dependency
`src/types.ts`	Added `sessionStore` getter and setter methods to `EggCore` interface
`test/fixtures/redis-session/config/plugin.js`	Updated Redis package name from `'egg-redis'` to `'@eggjs/redis'`

Sequence Diagram

sequenceDiagram
    participant App as Egg.js Application
    participant Core as EggCore
    participant Redis as Redis Session Store
    
    App->>Core: Set Session Store
    Core->>Redis: Configure Session Management
    Redis-->>Core: Store Configuration Confirmed

Poem

🐰 A Redis dance, a package's new name,
Hopping from egg to @eggjs's frame,
Types extend, dependencies align,
A bunny's upgrade, simply divine!
🔧 Code hops forward, smooth and clean! 🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

pkg-pr-new · 2025-01-21T16:39:28Z

Open in Stackblitz

npm i https://pkg.pr.new/eggjs/session/@eggjs/session@21

commit: 72b3ed8

socket-security · 2025-01-21T16:39:41Z

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/egg-redis@2.6.1

View full report↗︎

codecov · 2025-01-21T16:42:40Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0f06e00) to head (72b3ed8).
Report is 4 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##           master       #21       +/-   ##
============================================
+ Coverage   89.65%   100.00%   +10.34%     
============================================
  Files           4         4               
  Lines          87       109       +22     
  Branches       14        16        +2     
============================================
+ Hits           78       109       +31     
+ Misses          9         0        -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[skip ci] ## [4.0.1](v4.0.0...v4.0.1) (2025-01-21) ### Bug Fixes * should export sessionStore ([#21](#21)) ([30e2b25](30e2b25))

fix: should export sessionStore

72b3ed8

fengmk2 force-pushed the sessionStore branch from 7aefc82 to 72b3ed8 Compare January 21, 2025 16:40

fengmk2 merged commit 30e2b25 into master Jan 21, 2025
11 checks passed

fengmk2 deleted the sessionStore branch January 21, 2025 16:42

fengmk2 pushed a commit that referenced this pull request Jan 21, 2025

Release 4.0.1

99eb670

[skip ci] ## [4.0.1](v4.0.0...v4.0.1) (2025-01-21) ### Bug Fixes * should export sessionStore ([#21](#21)) ([30e2b25](30e2b25))

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: should export sessionStore #21

fix: should export sessionStore #21

Uh oh!

fengmk2 commented Jan 21, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 21, 2025 •

edited

Loading

Rate limit exceeded

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Jan 21, 2025 •

edited

Loading

Uh oh!

socket-security bot commented Jan 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

codecov bot commented Jan 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: should export sessionStore #21

fix: should export sessionStore #21

Uh oh!

Conversation

fengmk2 commented Jan 21, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Sequence Diagram

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

pkg-pr-new bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jan 21, 2025

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fengmk2 commented Jan 21, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 21, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

pkg-pr-new bot commented Jan 21, 2025 •

edited

Loading

socket-security bot commented Jan 21, 2025 •

edited

Loading