API change to event handling at the lower ginga viewer widget level#1138
Draft
API change to event handling at the lower ginga viewer widget level#1138
Conversation
ejeschke
force-pushed
the
new-event-handling
branch
from
51400b2 to
8f1e18f
Compare
ejeschke
force-pushed
the
new-event-handling
branch
from
8f1e18f to
de38342
Compare
The event handling API at the ginga viewer lower level is changed so that event objects are passed for all event callbacks at this level. This includes the following callbacks: map, focus, enter, leave, key-press, key-release, button-press, button-release, motion, scroll, swipe, pinch, pan Note that this level of API use is recommended only for users adding a viewer widget to their own viewer. Users of the reference viewer should be using the callbacks in ginga.Bindings, which have not changed. The reason for the change is to allow more flexible changes to the event system by changing the event in the future instead of adding fixed position arguments to the callback API.
ejeschke
force-pushed
the
new-event-handling
branch
from
de38342 to
aca96a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The event handling API at the ginga viewer lower level is changed so that event objects are passed for all event callbacks at this level. This includes the following callbacks:
map,focus,enter,leave,key-press,key-release,button-press,button-release,motion,scroll,swipe,pinch,pan.Note that this level of API use is recommended only for users adding a viewer widget to their own viewer. Users of the reference viewer should be using the callbacks in
ginga.Bindings, which have not changed. Developers of plugins for the reference viewer are unlikely to see much effect unless they are using one of the above callbacks.The reason for the change is to allow more flexible changes to the event system by changing the event in the future instead of adding fixed position arguments to the callback API.
Merging this PR should be done only for a major version release.