Add unit tests for iqcalc with mock_sky module#770
Open
ejeschke wants to merge 2 commits intoejeschke:mainfrom
Open
Add unit tests for iqcalc with mock_sky module#770ejeschke wants to merge 2 commits intoejeschke:mainfrom
ejeschke wants to merge 2 commits intoejeschke:mainfrom
Conversation
Owner
Author
|
Whups, need to add |
Collaborator
|
Is this the unit test you mentioned in #769 (comment) ? |
pllim
reviewed
May 22, 2019
Collaborator
pllim
left a comment
There was a problem hiding this comment.
@ejeschke , I feel like this is duplicating what is already in photutils; see https://photutils.readthedocs.io/en/stable/datasets.html .
Owner
Author
|
@pllim, good catch, I'm not super familiar with |
Owner
Author
Yep |
Owner
Author
|
Needs refactor to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more unit tests for
iqcalcmodule via a small utility module calledmock_sky.