Skip to content

Add unit tests for iqcalc with mock_sky module#770

Open
ejeschke wants to merge 2 commits intoejeschke:mainfrom
naojsoft:mock_sky
Open

Add unit tests for iqcalc with mock_sky module#770
ejeschke wants to merge 2 commits intoejeschke:mainfrom
naojsoft:mock_sky

Conversation

@ejeschke
Copy link
Owner

Adds more unit tests for iqcalc module via a small utility module called mock_sky.

@ejeschke ejeschke self-assigned this May 22, 2019
@ejeschke ejeschke added this to the 3.0 milestone May 22, 2019
@ejeschke ejeschke requested a review from pllim May 22, 2019 02:21
@ejeschke
Copy link
Owner Author

Whups, need to add scipy in the CI builds in order to add this. Alternatively, could test for scipy and skip tests for which it is needed when it is not installed. Hmmm...

@pllim
Copy link
Collaborator

pllim commented May 22, 2019

Is this the unit test you mentioned in #769 (comment) ?

Copy link
Collaborator

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ejeschke , I feel like this is duplicating what is already in photutils; see https://photutils.readthedocs.io/en/stable/datasets.html .

@ejeschke
Copy link
Owner Author

@pllim, good catch, I'm not super familiar with photutils, but it looks like it can generate good sources for testing iqcalc. Let me try modifying this PR to use it.

@ejeschke
Copy link
Owner Author

Is this the unit test you mentioned in #769 (comment) ?

Yep

@pllim pllim modified the milestones: 3.0, 3.1 Oct 30, 2019
@ejeschke ejeschke modified the milestones: 3.1, 3.2 Jul 9, 2020
@ejeschke
Copy link
Owner Author

ejeschke commented Jul 9, 2020

Needs refactor to use photutils.

@ejeschke ejeschke modified the milestones: 3.2, 3.3 May 27, 2021
@ejeschke ejeschke modified the milestones: 3.3, 3.4 Feb 18, 2022
@ejeschke ejeschke changed the base branch from master to main July 12, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants