Skip to content

WIP: add Undistort plugin -- roughly correct for SIP distortion#816

Closed
ejeschke wants to merge 2 commits intoejeschke:masterfrom
naojsoft:undistort-plugin
Closed

WIP: add Undistort plugin -- roughly correct for SIP distortion#816
ejeschke wants to merge 2 commits intoejeschke:masterfrom
naojsoft:undistort-plugin

Conversation

@ejeschke
Copy link
Owner

@ejeschke ejeschke commented Jan 9, 2020

Adds a plugin called "Undistort".

It does a quick image correction for distortion information contained in the SIP WCS.

Load an image that is distorted. Open Utils->Undistort. Click the "Undistort" button to quickly correct for distortion.

NOTE: in this implementation, NaNs are substituted for pixels that are not mapped in the distortion-corrected image.

@ejeschke
Copy link
Owner Author

ejeschke commented Jan 9, 2020

@pllim, is this more what you had in mind, rather than #813?

Copy link
Collaborator

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we close this in favor of #813 ?

@ejeschke
Copy link
Owner Author

If #813 seems promising we can close this one. Let's leave it open until we decide about it. Priority for evaluation should be #813 first.

Adds a plugin called "Undistort".  It does a quick image correction for
distortion information contained in the SIP WCS.
@ejeschke ejeschke removed this from the 3.1 milestone Jul 9, 2020
@ejeschke ejeschke mentioned this pull request Jul 20, 2020
3 tasks
@ejeschke
Copy link
Owner Author

ejeschke commented Feb 8, 2021

Should we close this in favor of #813 ?

@pllim, I vote in favor of closing this PR.

@ejeschke
Copy link
Owner Author

ejeschke commented Feb 8, 2021

Unmerged.

@pllim
Copy link
Collaborator

pllim commented Feb 8, 2021

Okay. Thanks!

@pllim pllim closed this Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants