Add new "-M" option, so that -wM would produce both weekly and monthly#104
Open
sobomax wants to merge 6 commits intoejwa:masterfrom
Open
Add new "-M" option, so that -wM would produce both weekly and monthly#104sobomax wants to merge 6 commits intoejwa:masterfrom
sobomax wants to merge 6 commits intoejwa:masterfrom
Conversation
cause gitinspector output *both* monthly and weekly stats for the period in question.
Member
|
Hi @sobomax. Yes, there might be some credence to adding this. I'm not completely convinced, but it is definitely worth considering. Some problems with the pull request, before this can even be considered for merging;
|
Author
|
Hi @adam-waldenberg, both suggestions have been implemented. Please check and let me know if anything else needs to be done. Thanks! |
Member
|
Thank you. I will play with this. I'm wondering if a -M flag is the best option for this... Maybe removing -w and introducing a "--period" flag that takes a string such as "m" (for months) or "wm" (for weeks and months) would be an idea... It would also make it more flexible. I'm torn, though. I need to think about it :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new "-M" option, which when used in conjunction with "-w" will cause gitinspector output both monthly and weekly stats for the period in question. It is useful in some cases to have both.