Conversation
…ncomplete docstring Co-authored-by: ekosman <10260165+ekosman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update repository organization for better usability
Fix infinite retry loops, bare asserts, double iteration counter, and stale docstring
Feb 21, 2026
ekosman
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several reliability and correctness bugs across the data loading and training pipeline. Key issues: retry loops with no exit condition could hang indefinitely, bare
assertstatements are silently stripped under-O, andself.iterationwas double-incremented per training step.Fixes
data_loader.py,features_loader.py): All threewhile not succretry loops now acceptmax_retries=10and raiseRuntimeErrorafter exhaustion instead of spinning foreverFileNotFoundError(features_loader.py):assert os.path.exists(path)replaced with explicit guards in bothFeaturesLoader._get_features_listandFeaturesLoaderVal._get_features_listself.iterationincrement (network/TorchUtils.py):self.iteration += 1appeared at both the top and bottom of thedo_epochloop body, advancing the counter by 2 per step — removed the duplicate at the bottomfeatures_loader.py):get_featurereturned_type_: _description_— replaced with accurate return type annotationtuple[Tensor, Tensor, int]and descriptionFeaturesLoader.__getitem__andFeaturesLoaderVal.__getitem__logged errors asVideoIter::— corrected to their actual class names💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.