Cross-links: differentiate URL format and htmx behavior per build type#2777
Open
Cross-links: differentiate URL format and htmx behavior per build type#2777
Conversation
Introduce useRelativePaths parameter to CodexAwareUriResolver so codex
builds produce path-only /r/{repo}/{path} URLs with htmx navigation,
while isolated builds produce absolute https://codex.elastic.dev URLs
with target=_blank. Assembler builds continue using their own
PublishEnvironmentUriResolver with htmx intact.
Clear isCrossLink flag only for isolated builds when the resolved URI
is absolute, so assembler same-site cross-links keep htmx behavior.
Use CodexHtmxAttributeProvider (with #codex-breadcrumbs) for codex
builds in ParserContext.
Improve cross-link error message to suggest adding the repo to
docset.yml cross_links.
Co-authored-by: Cursor <cursoragent@cursor.com>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
tests/Elastic.Documentation.Configuration.Tests/CrossLinkRegistryTests.cs
Fixed
Show fixed
Hide fixed
tests/Elastic.Documentation.Configuration.Tests/CrossLinkRegistryTests.cs
Fixed
Show fixed
Hide fixed
tests/Elastic.Documentation.Configuration.Tests/CrossLinkRegistryTests.cs
Fixed
Show fixed
Hide fixed
tests/Elastic.Documentation.Configuration.Tests/CrossLinkRegistryTests.cs
Fixed
Show fixed
Hide fixed
Mpdreamz
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
/r/{repo}/{path}URLs with htmx navigation (including#codex-breadcrumbssub-header replacement)https://codex.elastic.dev/r/{repo}/{path}URLs withtarget="_blank"and no htmxPublishEnvironmentUriResolverabsolute URLs with htmx intactdocset.ymlcross_linksWhy
elastic.co/docs, so cross-links are same-site and should also use htmxNotes
CodexAwareUriResolvernow accepts auseRelativePathsparameter to control relative vs absolute URI outputisCrossLinkflag inDiagnosticLinkInlineParseris only cleared forBuildType.Isolatedwith absolute URIs, preserving htmx for AssemblerParserContextconditionally usesCodexHtmxAttributeProviderfor Codex builds to include#codex-breadcrumbsin htmx swapsMade with Cursor