Conversation
reakaleek
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #2775
Summary
The
docs-builder changelog bundlecommand has some bugginess around the--directoryoption when thebundle.directorychangelog configuration setting exists.Implementation
ChangelogBundlingService.csBundleChangelogsArguments.Directoryis nowstring?so “not specified” is distinct from “specified”.ApplyConfigDefaultsonly applies config wheninput.Directory == null; if the user passes--directory .(or any path), that value is kept.ProcessProfileand call sites correctly support a null directory.ChangelogCommand.csDirectory = directoryinstead ofDirectory = directory ?? Directory.GetCurrentDirectory(), sonullis passed when--directoryis omitted.Tests
BundleChangelogs_WithConfigDirectory_WhenDirectoryNotSpecified_UsesConfigDirectory– asserts config is used whenDirectoryis null.BundleChangelogs_WithExplicitDirectory_OverridesConfigDirectory– asserts the CLI directory overrides config when--directoryis set, even when it equals the current directory.Steps to test
bundle.directoryis set in the changelog configuration file (e.g. todocs/changelog).224552.yamlintodocs/testand changed itstitlevalue so I'd know where it was being found).docs/testdirectory, I ran:--directoryoption with something other than the current directory. For example:bundle.directoryvalue instead of (or as well as) the--directoryvalue:info ::d.b.f.StopwatchFilter :: changelog bundle :: Starting... error::d.b.d.Log :: Directory does not exist (docs/changelog:0) The following errors and warnings were found in the documentation Error: Directory does not exist NOTE: docs/changelog--directory).Generative AI disclosure
Tool(s) and model(s) used: composer-1.5