Conversation
|
💚 CLA has been signed |
|
We've reportedly signed a contributor agreement; I'm not sure how to get it to be reflected here. |
|
Going to try closing and reopening |
|
cla/check |
|
@jpage-godaddy Regarding the CLA, my understanding is that you or someone at GoDaddy will need to send an email to cla-questions@elastic.co asking to add you to your corporate CLA. Per this on https://www.elastic.co/contributor-agreement
I don't know how to verify on my end whether GoDaddy has a corporate CLA. Let me know if you hit a wall here and I can start asking around. |
|
Running You'll have to avoid the |
trentm
left a comment
There was a problem hiding this comment.
Thanks for the PR!
The https://github.com/elastic/ecs-logging-nodejs/blob/main/docs/morgan.asciidoc#reference docs file should get an update for this. I can help with that if you like -- no need for you to learn asciidoc just for this.
Another request/comment below.
|
@trentm thanks for the review. I've made some updates and am ready for another pass. |
|
Is there any interest in merging this? Anything else you'd like to see? |
Support customization of fields on a per-request basis
5632bcb to
c008055
Compare
Support customization of fields on a per-request basis