Open
Conversation
phil-nelson
commented
Jul 29, 2022
| "brianium/paratest": "^3.1", | ||
| "monolog/monolog": "^2.0" | ||
| "squizlabs/php_codesniffer": "^3.7", | ||
| "brianium/paratest": "^6.6", |
Author
There was a problem hiding this comment.
These updates are required to be able to run tests with PHP 8.
phil-nelson
commented
Jul 29, 2022
| "monolog/monolog": "^2.0" | ||
| "squizlabs/php_codesniffer": "^3.7", | ||
| "brianium/paratest": "^6.6", | ||
| "monolog/monolog": "^2.5" |
Author
There was a problem hiding this comment.
Although still compatible with monolog < 2.5, ^2.5 is required for tests
❕ Build Aborted
Expand to view the summary
Build stats
Steps errors
Expand to view the steps failures
|
|
Maybe you can include diff from main...paveljanda:ecs-logging-php:main? (native PHP types) |
Member
|
run docs-build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update fixes an issue working with monolog 2.5 and above, where the IntrospectionProcessor added a
callTypefield to its output. Since theElasticCommonSchemaFormatterdoes not know about this field, it gets added as a top level key instead of withinlog.origineven when$useLogOriginFromContextis set. This can be demonstrated by simply checking out the main branch of this repo and runningcomposer install && composer test.This fixes the issue by adding
callTypeto the list of known origin keys and also uses it (if available, so will still work with monolog < 2.5) within thelog.origin.functionfield. E.g.MyClass::myFunctionorMyClass->myFunction.As a minor additional change it also marks compatibility with
psr/log2.x and 3.x.