Use localhost:8221 for enroll request when bootstrapping fleet-server#12917
Open
michel-laterman wants to merge 2 commits intoelastic:mainfrom
Open
Use localhost:8221 for enroll request when bootstrapping fleet-server#12917michel-laterman wants to merge 2 commits intoelastic:mainfrom
michel-laterman wants to merge 2 commits intoelastic:mainfrom
Conversation
f8b5283 to
c0da9f3
Compare
Contributor
|
This pull request does not have a backport label. Could you fix it @michel-laterman? 🙏
|
Contributor
💚 Build Succeeded
History
|
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use
localhost:8221for the enroll request the agent makes when enrolling into a local fleet-server. TLS verification is set to certificate mode if fleet-server isn't running as a plain HTTP server.Why is it important?
Removes the assumption that DNS resolution to the external fleet address functions during install time.
This can allow something like an external load balancer to use fleet-server's status endpoint to route requests only to fleet-server instances that are online.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog toolI have added an integration test or an E2E testCovered by existing bootstrap testDisruptive User Impact
N/A
How to test this PR locally
Bootstrap an elastic-agent instance with fleet-server; fleet-server should log the enroll request as one made to the internal port.
For example - install with the
--developoption, and deebug logs set has the following output: