Open
Conversation
💚 Build Succeeded
cc @jsoriano |
mrodm
reviewed
Sep 4, 2023
Contributor
mrodm
left a comment
mrodm
left a comment
There was a problem hiding this comment.
Should it be added a new changelog entry indicating that now it is supported multiple sample events in the package?
| value: "mysql" | ||
| - name: "two" | ||
| condition: | ||
| key: "sql.driver" |
Contributor
There was a problem hiding this comment.
Just to confirm, with this second sample configuration, would elastic-package (client) look for the first document where that key, in this example sql.driver, exists in the doc?
| vars: ~ No newline at end of file | ||
| vars: ~ | ||
|
|
||
| samples: |
Contributor
There was a problem hiding this comment.
As this samples map requires a specific structure, should this be defined/added into the spec of this file ? https://github.com/elastic/package-spec/blob/037631bddaffe6519b61eb41c186fb929675d6e1/spec/integration/data_stream/_dev/test/system/config.spec.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for multiple sample events. They can be named now
sample_event.json, orsample_event_<name>.json, where<name>is any string composed by letters or digits.Why is it important?
To support elastic/elastic-package#773.
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues