remove build-time entitlement for host network access#17
Open
jastang wants to merge 1 commit intoelastic:mainfrom
Open
remove build-time entitlement for host network access#17jastang wants to merge 1 commit intoelastic:mainfrom
jastang wants to merge 1 commit intoelastic:mainfrom
Conversation
Signed-off-by: Jason Tang <jason@upbound.io>
|
💚 CLA has been signed |
Author
|
CLA signed 👍🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
network: hostbuild-time entitlement. Docker daemon configurations may often not allow this, giving the user an error such as:failed to solve: granting entitlement network.host is not allowed by build daemon configurationAs far as I can tell, this is not needed at build time, and we already have the runtime entitlement with
network_mode: hostwhich should suffice for the proxy.