fix: preserve escape hatch through login redirect#179
Merged
Conversation
The adminDashboard=true override was lost when unauthenticated users were redirected to /login — the param got encoded inside continueTo rather than remaining a top-level query param. hasEscapeHatch now also checks inside continueTo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?adminDashboard=trueoverride param was lost when unauthenticated users hit the dashboard lockdown — the redirect to/loginencoded it insidecontinueTo(/login?continueTo=%2F%3FadminDashboard%3Dtrue) wherehasEscapeHatch()couldn't find ithasEscapeHatchnow also checks inside thecontinueToquery param for the escape hatchcontinueToscenario (28 total, all passing)Test plan
yarn test --testPathPattern dashboard-restriction— 28/28 passhttps://integration.storefront.elasticpath.com/?adminDashboard=truewhile logged out and confirm you reach the login page instead of being redirected to Commerce ManagercontinueToredirect, confirm the dashboard is accessible