Conversation
fix issue with incorrect pin
| ### | ||
| # ESP32 specific io_mux_reg.h port | ||
| ## | ||
| arsoienieonrstg |
| @@ -0,0 +1,551 @@ | |||
| /* | |||
|
|
||
| const hdr = "soc/io_mux_reg.h" | ||
|
|
||
| var SLP_OE* {.importcpp: "SLP_OE", header: hdr.}: int |
There was a problem hiding this comment.
I believe there's a new option which is to use let. Also, these should use importc?
| var SLP_OE* {.importcpp: "SLP_OE", header: hdr.}: int | |
| let SLP_OE* {.importc: "SLP_OE", header: hdr.}: int |
| when defined(esp32s3): | ||
| include ./esp32s3/io_mux_reg | ||
| elif defined(esp32c3): | ||
| include ./esp32c3/io_mux_reg |
There was a problem hiding this comment.
Nice, this pattern appears to be working well.
|
@faldor20 heya I reviewed this last year but forgot to submit the review. This still looks alright to me, pending my comments. |
|
Hey, I'm probably never going to get to this, I don't actually use nim for anything these days and it's been well over a year since I last even had it installed. You're welcome to take it over and merge it though :) |
That's too bad, but thanks for the heads up! |
2 participants
Added support for esp32c3 board