Skip to content

StripeDialog: Put the money icon in the right place depending on the locale #1663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tintou wants to merge 6 commits into
base: main
Choose a base branch
from
Open

StripeDialog: Put the money icon in the right place depending on the locale #1663

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f3cb5f
StripeDialog: Put the money icon in the right place depending on the …
tintou Sep 9, 2021
ef0d86c
Merge branch 'master' into tintou/money-position
meisenzahl Sep 9, 2021
cd9c469
Merge branch 'master' into tintou/money-position
danirabbit Sep 9, 2021
e16c7b6
Merge branch 'master' into tintou/money-position
danirabbit Sep 15, 2021
3ac2d57
Merge branch 'master' into tintou/money-position
cassidyjames Sep 15, 2021
a3bd9f9
Merge branch 'master' into tintou/money-position
Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Dialogs/StripeDialog.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,16 @@ public class AppCenter.Widgets.StripeDialog : Granite.Dialog {
var custom_amount = new Gtk.SpinButton.with_range (0, 100, 1) {
activates_default = true,
hexpand = true,
primary_icon_name = "currency-dollar-symbolic",
value = amount
};

// Account for languages that places the monetary sign after the number
if (_("$%d").split ("%d", 2)[0]._strip ().length > 0) {
custom_amount.primary_icon_name = "currency-dollar-symbolic";
} else {
custom_amount.secondary_icon_name = "currency-dollar-symbolic";
}

var selection_list = new Gtk.Grid () {
column_spacing = 6
};
Expand Down