Show ongoing operations #2105
Draft
Show ongoing operations #2105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Ok nvm the installed_apps_changed signal doesn't get fired at all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a install button is clicked we add the app to the updates ListStore on the AppListUpdateView. There it shows a progressbutton with cancel ability and gets added to the installed apps list once its done as then the
installed_apps_changedsignal gets fired and the view updated shortly after.Regarding the current behavior I'm not sure but I think it's wrong anyways because currently an app gets added to the update liststore only after it was installed and the installed_apps_changed signal was then already fired so that it also doesn't get removed but stays there.
To test this you might want to use a large app like GNOME Builder etc. to have enough time to switch over
Fixes #14