-
-
Notifications
You must be signed in to change notification settings - Fork 105
SearchView: use GridView #2325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SearchView: use GridView #2325
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
@danirabbit grid view has to be directly inside a scrolled window otherwise these weird bugs appear. This also makes sense because otherwise there would be no advantage of using grid view regarding performance since it won't know which children are visible. |
|
Oh okay damn. I guess we will have to sacrifice the clamp then haha |
|
@danirabbit I started to work on a kind of scrollable pass through a while back that can handle this but idk if that will ever work reliably and I currently don't have a lot of time to work on it 🤷 |
|
Yeah I think there's other things I can do instead anyways, like clamp the contents of a search item row and set max columns in the grid |
leolost2605
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't test rn but code lgtm
|
There's |
Omg thank you! |
Sets us up for #2272