UpdateManager: handle metered network #2344
Open
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolost2605
requested changes
Sep 9, 2025
Member
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
Can we maybe introduce something like a do_automatic_refresh method that does this check (and maybe in the future other ones) instead of doing the check manually three times?
Also this would have the benefit that a scenario like
No wifi -> connect hot spot -> it isn't marked as metered yet -> mark as metered (assuming this is done within 60 seconds)
would correctly be covered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #417
If we're on a metered network, don't refresh automatically