Cleanup change information #2362
Draft
+93
−172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update info is only required for updates whereas change info is required for all package operations. Also update info only makes sense for runtime updates. Therefore split the update info from the change info. This will allow for easier rework of the update process later to reduce overhead by trying to fit runtime updates into a normal package and allows fixing some things with the change info without having to worry about it for now.
We never actually show the finished state so remove it and instead immediately switch back to unknown state.
Instead of manually passing the cancellable, include it in change info. This makes it easier to keep the change info status in sync with the cancelled state. Notably this allows to fix an issue where clicking cancel seemingly didn't do anything until the backend actually drops out of the transaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.