Handle cancellable in change information #2365
Open
+46
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leolost2605
force-pushed
the
leolost/cancellable-in-change-info
branch
from
c1e48f9 to
366afaf
Compare
danirabbit
reviewed
Dec 2, 2025
src/Widgets/ProgressButton.vala
Outdated
|
|
||
| clicked.connect (package.change_information.cancel); | ||
|
|
||
| package.change_information.bind_property ("can-cancel", this, "sensitive", SYNC_CREATE); |
Member
There was a problem hiding this comment.
Hm this seems like maybe it should use a GLib.Action and then we can disable/enable the action?
leolost2605
force-pushed
the
leolost/cancellable-in-change-info
branch
from
3763ed9 to
0e726c3
Compare
leolost2605
force-pushed
the
leolost/cancellable-in-change-info
branch
from
0e726c3 to
6310e2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the user wouldn't receive feedback when clicking cancel. The cancel button will now immediately go insensitive and the tooltip text will say cancelling until the operation was actually cancelled.