Reload installed packages sync #2368
Open
+42
−128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are only two occasions where we have to do this and in both cases it's ok to do it synchronously: - Startup: We have to wait anyways - External change to the apps: Then you're probably not in the AppCenter anyways. Also fetching installed applications is really fast so it wouldn't even be noticable. Also this will safe us the is_package_installed call which does exactly the same IO as getting all installed apps and is already happening synchronously multiple times on startup and when using AppCenter e.g. when installing apps.
Member
|
@leolost2605 can you resolve conflicts here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking if an app is installed does exactly the same IO as checking if all apps are installed and we are already doing the former synchronous.
So instead reload all installed apps synchronous and remove the check for a single app.
See the individual commits for details.
Use rebase to merge