Skip to content

Conversation

@danirabbit
Copy link
Member

Fixes #2371

Can be rebase merged. Fixes non-mouse activation methods

@danirabbit danirabbit requested a review from a team October 31, 2025 17:18
@danirabbit danirabbit mentioned this pull request Dec 2, 2025
1 task
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the actionable interface that listboxrow and flowboxchild implement?

@danirabbit
Copy link
Member Author

Looks like listboxrow implements actionable, but not flowboxchild. I'll try it! Thanks for the suggestion

@danirabbit
Copy link
Member Author

@leolost2605 actually I don't think we can because these are bin subclasses not listboxrow or flowboxchild because sometimes they're used in FlowBox and sometimes in ListBox

Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like listboxrow implements actionable, but not flowboxchild. I'll try it! Thanks for the suggestion

Ah right

@leolost2605 actually I don't think we can because these are bin subclasses not listboxrow or flowboxchild because sometimes they're used in FlowBox and sometimes in ListBox

I meant in the widget create funcs but given that we don't use listbox that often this LGTM

@danirabbit danirabbit enabled auto-merge (rebase) December 9, 2025 15:31
@danirabbit danirabbit force-pushed the danirabbit/lists-activate branch from 8f3aefd to 65b3ddd Compare December 9, 2025 15:31
@danirabbit danirabbit merged commit 1309b93 into main Dec 23, 2025
4 checks passed
@danirabbit danirabbit deleted the danirabbit/lists-activate branch December 23, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revert change from list/flowbox activate to click controller

4 participants